Re: [PATCH net-next v5 3/3] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver

On Tue, Aug 4, 2026 at 1:17=E2=80=AFPM <[email protected]> wrote:

> [Severity: Low]
> Should this exit condition explicitly check for val < 0?
>
> If dap8211r_read_ext() returns a negative error code, this loop currently
> terminates only because negative values in two's complement happen to hav=
e
> BIT(15) set. Relying on this coincidence might mask errors if a different
> register or bit is polled in the future.

The driver already checks this after read_poll_timeout() returns.
The check is present and handles negative error values.

> [Severity: Medium]
> The function's docstring mentions "Software reset to apply settings", but=
 here
> the RGMII configuration is written after the reset completes.
>
> Does this PHY require the settings to be written before the software rese=
t in
> order to latch them properly?

This was already discussed. The reset is active low and self-clearing;
RGMII configuration is applied after the reset completes, which is the corr=
ect
sequence.

--
Best regards,
Artem