Re: [PATCH] drm/virtio: use the DMA API for resource backing on Xen
Benjamin Leggett <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.freedesktop.lists.dri-devel |
|---|---|
| Message-ID | <[email protected]> |
[email protected] writes: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > [Severity: High] > This is a pre-existing issue, but while enabling the DMA API for Xen PV > domains, does this leave guest-bound transfers vulnerable to data corruption > with SWIOTLB bounce buffers? Yep, preexisting issue, but not reachable via plain `virtio-vga`. Only reachable, AFAICT, if `has_virgl_3d` is enabled. The missing `_for_cpu`` sync is pre-existing since 8f44ca223345 and pretty orthogonal to this patch. A correct fix belongs in the completion path rather than at submission, anyway, so it should be its own separate patch. Happy to do that in a followup/separate patch, if requested.