Re: [PATCH] i2c: imx: add I2C_M_REV_DIR_ADDR and I2C_M_NOSTART

Vincent Jardin <[email protected]>
Newsgroups dev.linux.lists.sashiko-reviews,dev.linux.lists.imx
Message-ID <[email protected]>
Hi Mr. Bot,

> Pre-existing issues:
> - [High] Zero-length I2C reads cause a NULL pointer dereference and kernel panic in the interrupt handler due to integer underflow.

This analysis seems to be correct but it is not the purpose of this feature
update which does only "move" this block of code for the needed new feature.

The pre-existing issue/topic may needs its own specific "Fix" commit.

> Since the I2C core sets msg->buf to NULL for zero-length messages, does this
> result in the driver writing to a NULL pointer and causing a kernel panic?

I think your analysis it not correct.

thanks for the reviews,
  Vincent
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.