Re: [PATCH] perf test sample-parsing: Validate PERF_FORMAT_GROUP values without LOST

PVS Narasimha Rao <[email protected]>
Newsgroups dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-perf-users
Message-ID <[email protected]>
Hi Namhyung,

Thanks for the review.

I reproduced it with gdb and confirmed the mismatch: the values in
do_test() are a plain array of struct sample_read_value with a 24-byte
stride, while sample_read_value_size() is 16 without PERF_FORMAT_LOST.
So the synthesizer reads overlapping bytes, and the test compares the
same garbage on both sides and passes.

read.group.values is expected to be packed per read_format, though
evsel__parse_sample() points it into the event data, and perf inject
feeds such a sample straight back to perf_event__synthesize_sample().
So I plan to fix the test input rather than the synthesizer.

I'm preparing v2 and will send it shortly.

Thanks,
Narasimha
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.