Re: [PATCH v6 2/3] pwm: add Andes PWM driver support

Hello,

On Thu, Jun 25, 2026 at 10:46:13AM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The driver fails to update the hardware PARK level to the inactive state when disabling the PWM channel, leaving the output stuck ON or at the wrong polarity.

I didn't look in detail into the patch yet, but I think the review
feedback here is misleading. There is no promise about a hardware state
for a disabled channel. The only objective is to save power.

Having said that, it's *nice* to drive the inactive level, but if that
isn't easily possible (e.g. because the output goes to high-Z on
disable) the primary objective is to save power.

So I guess the feedback is OK, but not "High".

> Additionally, if the polarity changes while the channel is disabled, will the
> hardware's inactive level fail to update?

This is in the same category. It's a bit surprising, but well in the
limits of what a PWM consumer must expect.

Best regards
Uwe

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmp5WI0ACgkQj4D7WH0S
/k6uvgf/QZmDu/btQL6geT+qqHEQN7l+EK0l9p3A+CrqaMHlQP2lPn7VVPNxiinb
wDcvRoLSatNz6x9a8ER4AFNJoFioKAltqvCK86Ti0UJuN7+VArjfPZJAl3mtmio0
YOLXdH7PMqbqWuzhBxdMUXavTZnFA+Hmg+Vp9HmgJExrRqqk6IoebudKzXL7F3T4
bYD2F02Gd+oeDjBLxDU93erNxo2G+KHZFF594ZjrO80bqREwoN9cIvqygeaNBnVn
uhoE/oJ5VfFkR+HyXpZnHjSKpqK6JzF9ItcyRvlQih0TyDH2zrm1LB0wZKnyVGJF
BdAYmdSKXBufQIGjYZLjGkQWSnsEDw==
=L6CL
-----END PGP SIGNATURE-----