Re: [PATCH v4 01/11] liveupdate: Add LIVEUPDATE_GUEST_MEMFD config option

Thanks for reviewing it.

Ackerley Tng <[email protected]> writes:

> [email protected] writes:
>
>>>
>>> +config LIVEUPDATE_GUEST_MEMFD
>>> +	bool "Live update support for guest_memfd"
>>> +	depends on LIVEUPDATE
>>> +	depends on KVM_GUEST_MEMFD
>>> +	default LIVEUPDATE
>>
>> [Severity: Medium]
>> Is the implementation for this feature missing from this patch?
>>
>> The commit message notes that this patch enables live update support for KVM
>> guest_memfd files, but the newly added LIVEUPDATE_GUEST_MEMFD symbol appears
>> to be unreferenced in the tree. Since there are no Makefiles, C files, or
>> preprocessor checks that use it, this currently acts as dead code.
>>
>> Could the implementation be missing, or was this intended to be introduced as
>> part of a larger series where the symbol is used in a subsequent patch?
>>
>
> Sashiko is right here, I think this patch should be squashed with the
> first usage.

Sure, will update it.

>
>>> +	help
>>> +	  Enable live update support for KVM guest_memfd files. This allows
>>> +	  preserving VM Memory backed by guest_memfd file across kernel live
>>> +	  updates.
>>> +
>>> +	  This can only be used for the guest_memfd that are fully-shared
>>> +	  and pre-faulted.
>>> +
>>> +	  If unsure, say N.
>>> +
>>>  endmenu
>>
>> --
>> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1