Re: [PATCH] clk: davinci: guard da850-specific init data references

On Tue, Aug 11, 2026 at 12:17 PM <[email protected]> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The patch uses a non-existent Kconfig macro `CONFIG_COMMON_CLK_DAVINCI_DA850` to guard DA850-specific clock definitions, which will unconditionally disable them.
> --
>
> --- Patch [1]: [PATCH] clk: davinci: guard da850-specific init data references ---
> commit 8310fd74805280b1ea31726bf5935e313dcdb916
> Author: Rosen Penev <[email protected]>
>
> clk: davinci: guard da850-specific init data references
>
> This commit attempts to fix undefined reference link errors in COMPILE_TEST
> builds by wrapping DA850-specific clock data and declarations in a new
> preprocessor guard.
>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> > diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c
> > index f73b0ac5d8a08..af95dc27f840d 100644
> > --- a/drivers/clk/davinci/pll.c
> > +++ b/drivers/clk/davinci/pll.c
> > @@ -841,17 +841,23 @@ int of_davinci_pll_init(struct device *dev, struct device_node *node,
> >       return 0;
> >  }
> >
> > +#ifdef CONFIG_COMMON_CLK_DAVINCI_DA850
>
> [Severity: High]
> Does the CONFIG_COMMON_CLK_DAVINCI_DA850 Kconfig option actually exist?
yes it does...
>
> It appears this should be checking CONFIG_ARCH_DAVINCI_DA850 instead. As
> currently written, this guard evaluates to false unconditionally. Will this
> cause DA850 devices to fail to boot because their early clocks and match
> tables (in both pll.c and psc.c) are no longer compiled in?
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1