Re: [PATCH v1 2/5] ASoC: qcom: q6prm: Fix QAIF clock ID typo

On Sun, Aug 09, 2026 at 05:57:18PM +0530, Prasad Kumpatla wrote:
> 
> On 8/9/2026 12:15 AM, [email protected] wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] The patch series breaks `git bisect` by splitting a macro rename across commits without retaining aliases, causing an intermediate build failure.
> > --
> > 
> > --- Patch [2]: [PATCH v1 2/5] ASoC: qcom: q6prm: Fix QAIF clock ID typo ---
> > commit 2d0653a87462572279fa5b7912ec981aed567a40
> > Author: Prasad Kumpatla <[email protected]>
> > 
> > ASoC: qcom: q6prm: Fix QAIF clock ID typo
> > 
> > The Audio IF QAIF clock IDs were introduced with a "LAPSS" prefix instead
> > of "LPASS". This commit renames the definitions and updates their users
> > accordingly.
> > 
> > Link: https://sashiko.dev/#/patchset/[email protected]
> > 
> > > diff --git a/sound/soc/qcom/qdsp6/q6prm-clocks.c b/sound/soc/qcom/qdsp6/q6prm-clocks.c
> > > index f613e2aee75e6..b4f9abbe02cb0 100644
> > > --- a/sound/soc/qcom/qdsp6/q6prm-clocks.c
> > > +++ b/sound/soc/qcom/qdsp6/q6prm-clocks.c
> > > @@ -64,34 +64,34 @@ static const struct q6dsp_clk_init q6prm_clks[] = {
> > >   	Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_MCLK),
> > >   	Q6PRM_CLK(LPASS_CLK_ID_WSA2_CORE_TX_2X_MCLK),
> > >   	Q6PRM_CLK(LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK),
> > > -	Q6PRM_CLK(LAPSS_CLK_ID_QAIF_IF0_IBIT),
> > [Severity: Low]
> > Does this patch series break git bisect by splitting a macro rename across
> > commits?
> > 
> > While this regression is fixed in this commit, it appears the preceding
> > dt-bindings commit removes LAPSS_CLK_ID_QAIF_IF0_IBIT and related macros
> > from include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h.
> > 
> > Because q6prm_clks still references those removed macros at the preceding
> > dt-bindings commit, it causes an intermediate build failure when compiling
> > the kernel at that point.
> > 
> > Should the dt-bindings commit temporarily retain the old misspelled macros as
> > aliases until the driver is migrated, or should these changes be squashed?
> 
> Hi Sashiko,
> 
> Thanks for reviewing.
> 
> The series remains bisectable as the renamed clock IDs are not
> referenced by any in-tree users before the corresponding Q6PRM updates.

Really? git grep LAPSS_CLK_ID_QAIF_IF0_IBIT told me different story. And
it is even YOUR code which is reported by grep.


Best regards,
Krzysztof