Re: [PATCH v10 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller

On Mon, Aug 10, 2026 at 09:49:27PM +0300, Stefan Dösinger wrote:
> Am Montag, 10. August 2026, 18:38:05 Ostafrikanische Zeit schrieb Rob Herring:
> > On Mon, Aug 10, 2026 at 07:12:23AM +0000, [email protected] wrote:
> > > Thank you for your contribution! Sashiko AI review found 2 potential
> > > issue(s) to consider: - [Medium] Missing `resets` property definition in
> > > the YAML schema. - [Medium] Missing `simple-mfd` in compatible string
> > > list for syscon with children.
> > Neither of these look valid to me.
> 
> Yeah, I removed the resets property in response to Krzysztof's feedback [0]. 
> And the syscon-reboot is registered by the MFD driver, which in turn goes back 
> to Conor's suggestion at [1].
> 
> Should I reply to the list when I think Sashiko produced a false warning? In a 
> way it feels like fighting windmills, as it will likely bring up the same 
> warning for further patch revisions.

Yes, otherwise the maintainers have to think about it first. :)

There's not a feedback loop in place though for sashiko. Hopefully that 
changes. Adding more detail in the commit msg might help. If it's just 
blunt info for guiding sashiko, I would put it after the '---'. 

> It does find a lot of real problems though and as a newbie contributor I feel 
> like it is a valuable tool.

That's good to hear.

Rob