Re: [PATCH bpf-next v2 6/6] selftests/bpf: Add tests for fault prone loads out of RCU pointers

On 8/15/26 12:03 AM, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The newly added BPF programs do not execute the vulnerable instructions at runtime and lack explicit verifier log assertions, failing to provide robust regression coverage.
Nope, its basically load coverage (ASSERT_OK(err, "skel_load") in test_success()),
meaning we make sure the assertion on patch 4/6 in bpf_convert_ctx_accesses()
doesn't trigger if this is forgotten to get rewritten as probed pointer:

         if (verifier_bug_if(bpf_may_fault_on_deref(ptr_type), env,
                             "access to a fault prone pointer is not rewritten as a probed one"))
                 return -EFAULT;