Re: [PATCH] netdevsim: update rxq->napi pointer during queue reset

Subasri S <[email protected]>
Newsgroups dev.linux.lists.sashiko-reviews,org.kernel.vger.bpf
Message-ID <CABfayGNZF553ZW=QoSkwA8YtRoDAQ5RP=MGyGXEbzbegYBN10w@mail.gmail.com>
On Wed, Aug 12, 2026 at 7:32 PM <[email protected]> wrote:
> Earlier in this function (nsim_queue_start), there is an early return
> for rq_reset_mode == 1 that bypasses the new restoration code:
>
> drivers/net/netdevsim/netdev.c:nsim_queue_start() {
>         ...
>         if (ns->rq_reset_mode == 1) {
>                 ns->rq[idx]->page_pool = qmem->pp;
>                 napi_enable_locked(&ns->rq[idx]->napi);
>                 return 0;
>         }
>         ...
> }
>
> Does this skip restoring rxq->napi, leaving it NULL and preventing XSK busy
> polling from working after a reset in mode 1?

Yes, I missed to handle the case when reset mode is 1. Sent a v2 patch fixing
this - https://lore.kernel.org/netdev/[email protected]/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.