Re: [PATCH 3/4] drm/amdgpu: Remove is_idle (non trivial functions)

* [email protected] ([email protected]) wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Incomplete API cleanup: The `is_idle` function pointer remains defined in `struct amd_ip_funcs`.
> --
> 
> --- Patch [3]: [PATCH 3/4] drm/amdgpu: Remove is_idle (non trivial functions) ---
> commit cf17e80a1ef9c0d7e6925465357af056c949e840
> Author: Dr. David Alan Gilbert <[email protected]>
> 
> drm/amdgpu: Remove is_idle (non trivial functions)
> 
> This commit removes the various is_idle implementations across the amdgpu
> driver since the method is never called. The same logic is mostly duplicated
> in the wait_for_idle method which remains in use.
> 
> > diff --git a/drivers/gpu/drm/amd/amdgpu/cik_ih.c b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> > --- a/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> [ ... ]
> > @@ -435,7 +424,6 @@ static const struct amd_ip_funcs cik_ih_ip_funcs = {
> >  	.hw_fini = cik_ih_hw_fini,
> >  	.suspend = cik_ih_suspend,
> >  	.resume = cik_ih_resume,
> > -	.is_idle = cik_ih_is_idle,
> >  	.wait_for_idle = cik_ih_wait_for_idle,
> 
> [Severity: Low]
> Since we are removing the .is_idle assignments across the tree, is it also
> worth removing the is_idle function pointer from the struct amd_ip_funcs
> definition in drivers/gpu/drm/amd/include/amd_shared.h to complete the
> API cleanup?

That's what I do in the next patch!

Dave

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/