Re: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Incomplete support for Exynos 5515 causes driver probe failure
> --
> 
> --- Patch [1]: [PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible ---
> commit 5ce6d6fa94d63e1a87277e33f24686ff951995c4
> Author: Aiden Isik <[email protected]>
> 
> dt-bindings: hwinfo: samsung,exynos-chipid: Add exynos5515 compatible
> 
> This commit adds the samsung,exynos5515-chipid compatible string to the
> exynos-chipid device tree binding. It specifies that it should use the
> samsung,exynos850-chipid compatible string as a fallback.
> 
> > diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > index b9cdfe52b62ff..619faf33214bd 100644
> > --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
> > @@ -25,6 +25,7 @@ properties:
> >        - items:
> >            - enum:
> >                - samsung,exynos2200-chipid
> > +              - samsung,exynos5515-chipid
> 
> [Severity: Medium]
> Will this compatible string cause a probe failure on Exynos 5515 hardware?
> 
> Because this binding uses the samsung,exynos850-chipid fallback, the
> exynos-chipid driver will attempt to probe on Exynos 5515 hardware.
> However, if the Exynos 5515 product ID is not added to the soc_ids array
> in drivers/soc/samsung/exynos-chipid.c, exynos_product_id_to_name() will
> return NULL:
> 
> drivers/soc/samsung/exynos-chipid.c:exynos_chipid_probe() {
>     ...
>     soc_dev_attr->soc_id = exynos_product_id_to_name(soc_info.product_id);
>     if (!soc_dev_attr->soc_id)
>         return dev_err_probe(dev, -ENODEV, "Unknown SoC\n");
>     ...
> }
> 
> Does the driver need a companion patch to add the Exynos 5515 product ID
> so that it can successfully probe rather than returning -ENODEV?
> 
> >                - samsung,exynos7885-chipid
> >                - samsung,exynos8895-chipid
> >                - samsung,exynos9610-chipid
> 
> --

The Exynos5515 device tree also uses samsung,exynos850 chipid, just like every other 850-compatible-chipid device tree.

> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
>