Re: [PATCH 05/11] drm/bridge: panel: add a panel_bridge to every panel

On Fri Aug 14, 2026 at 4:25 PM CEST, sashiko-bot wrote:

[...]

>> diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
>> index f8f6082e637fd..95fc95d1b4b7a 100644
>> --- a/drivers/gpu/drm/drm_panel.c
>> +++ b/drivers/gpu/drm/drm_panel.c
>> @@ -453,6 +453,9 @@ void *__devm_drm_panel_alloc(struct device *dev, size_t size, size_t offset,
>>
>>  	drm_panel_init(panel, dev, funcs, connector_type);
>>
>> +	panel->bridge = devm_drm_panel_bridge_add(dev, panel);
>> +	WARN_ON(!panel->bridge);
>
> [Severity: Medium]
> Will this check actually catch failures? devm_drm_panel_bridge_add()
> returns an ERR_PTR on failure, rather than NULL.

Indeed, will fix in v2.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com