Re: [PATCH net v2] net/iucv: descend into net/iucv independently of IUCV
Alexandra Winter <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-s390,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 17.08.26 14:06, Alexandra Winter wrote: > > > On 16.08.26 15:55, [email protected] wrote: >> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: >> >> New issues: >> - [High] Unconditional descent into net/iucv/ causes a vmlinux linker error when CONFIG_AFIUCV=y and CONFIG_IUCV=m. > > @Pengpeng Hou, > if it easier, you can also fix this issue by making CONFIG_AFIUCV depend on CONFIG_IUCV. > I see no practical scenario where we would want AFIUCV without IUCV. > And I agree with Sashiko. I did not verify this combination with your initial RFC, sorry. So I propose to depend AFIUCV on IUCV instead of your patch. Do you want to send such a patch, or do you want me to do that?