Re: [PATCH 1/7] dt-bindings: dma: ti,cppi41: Convert to DT schema
Bhargav Joshi <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.infradead.lists.linux-phy,org.kernel.vger.dmaengine,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <CAOWyW_4YmQ=Dkd9Wr57wxCfWJKmFVOA7BL9fkTiu7NcL=gFFtA@mail.gmail.com> |
On Tue, Aug 18, 2026 at 3:28 AM <[email protected]> wrote: > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Medium] The newly added deprecated properties `#dma-channels` and `#dma-requests` lack a type reference, which will cause `dt_binding_check` to fail. anything that starts with # dtschema already defines this as single-cell so no need for any $ref > - [Medium] The `interrupts` property is strictly required by the hardware and driver but is missing from the global or variant-specific `required` lists, while `interrupt-names` is required without `interrupts`. yes , will fix in v2