RE: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add right justify property
Xin Ji <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <DM6PR04MB69700C246B6CF8ED6EBF16DFC7A52@DM6PR04MB6970.namprd04.prod.outlook.com> |
OK, I'll try to use fmt HDMI_RIGHT_J > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) > to consider: > - [Medium] Adding a vendor-specific DT property for audio interface format > bypasses standard ASoC DAI format negotiation. > -- > > --- Patch [1]: [PATCH 1/2] dt-bindings: drm/bridge: anx7625: Add right justify > property --- Please note that due to recitation restrictions, I cannot quote the > original patch code directly. The review below is provided as a free-form > summary of the findings. > > commit c7f75f4b785470ba45b421324266273f5142da0b > Author: Xin Ji <[email protected]> > > dt-bindings: drm/bridge: anx7625: Add right justify property > > This commit adds a new boolean property to the analogix,anx7625 device > tree bindings. The property controls whether the driver enables the audio > right justify function for the data stream. > > [Severity: Medium] > Does adding a vendor-specific devicetree property for the audio interface > format bypass the standard ASoC DAI format negotiation? > > The standard hdmi-codec framework already supports right justified formats > using the existing DAI format structures, which are normally passed > dynamically to the driver's hw_params callback based on standard sound > card properties. > > Creating a custom property like analogix,audio-right-justify-enable hardcodes > this configuration statically in the devicetree, which creates a permanent ABI. > Should this driver instead rely on the standard hdmi-codec API to handle the > DAI format negotiation rather than introducing a custom vendor property? > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/20260818020559.961335- > [email protected]?part=1