Re: [PATCH v2 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor

Dear Rob,

Thanks for confirming Sashiko's review.

On 8/12/2026 11:16 AM, Rob Herring wrote:
> On Thu, Aug 06, 2026 at 07:20:54AM +0000, [email protected] wrote:
>> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>> - [Medium] Missing reference to standard video interface devices schema forbids common camera properties.
> 
> Yes.

Added

allOf:
   - $ref: /schemas/media/video-interface-devices.yaml#

>> - [Low] The `port` node does not explicitly require an `endpoint` child node.
> 
> No.
> 
>> - [Low] The fixed I2C address is not properly constrained to 0x1A.
> 
> Yes.

This was my mistake in the description. The IMX908 supports multiple I2C 
target addresses selected through the SLAMODE0 and SLAMODE1 pins, so the 
address is not fixed.

I changed the last line of the description to :

"The I2C target address is selected by the SLAMODE0 and SLAMODE1 pins."

and kept the existing reg definition.

Best Regards,

Lachlan