Re: [PATCH RFC v2 02/13] proc: add config option SYSCTL_MODULE_ALIASES
Mauricio Faria de Oliveira <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,dev.linux.lists.mptcp,org.kernel.vger.bpf,org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-18 23:37, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] The Kconfig option `SYSCTL_MODULE_ALIASES` is introduced but never used in the codebase. It's used in later patches; apparently not a problem. > - [Low] Grammatical error in the Kconfig help text: 'This options adds' should be 'This option adds'. Fixed. > -- > > --- Patch [2]: [PATCH RFC v2 02/13] proc: add config option SYSCTL_MODULE_ALIASES --- > commit 931fa1a5261f1467829ad7b64b387a4e318eb177 > Author: Mauricio Faria de Oliveira <[email protected]> > > proc: add config option SYSCTL_MODULE_ALIASES > > Add a config option for the 'sysctl:' module aliases feature. > >> diff --git a/fs/proc/Kconfig b/fs/proc/Kconfig >> index 24f5a36f45df8..e6591ec4bcf0a 100644 >> --- a/fs/proc/Kconfig >> +++ b/fs/proc/Kconfig >> @@ -98,6 +98,19 @@ config SYSCTL >> building a kernel for install/rescue disks or your system is very >> limited in memory. >> >> +config SYSCTL_MODULE_ALIASES >> + bool "'sysctl:' module aliases (EXPERIMENTAL)" > > [Severity: Low] > Is this config option fully implemented in this commit? The > SYSCTL_MODULE_ALIASES option is being introduced here, but it doesn't look > like CONFIG_SYSCTL_MODULE_ALIASES is referenced anywhere else in the C code, > Makefiles, or scripts. > >> + depends on SYSCTL && MODULES >> + default n >> + help >> + The /proc/sys files registered by a module do not exist until the >> + module is loaded; meanwhile, userspace cannot find or access them. >> + >> + This options adds 'sysctl:*/<path>/<file>' module aliases for the > > [Severity: Low] > This isn't a bug, but there is a typo in the help text: "This options adds" > should likely be "This option adds". > >> + /proc/sys files registered by modules, so modules for nonexistent >> + files can be loaded with 'modprobe sysctl:/proc/sys/<path>/<file>' >> + by userspace when needed. -- Mauricio