Re: [PATCH 1/2] arm64: dts: imx8mp-evk: enable CBTU02043 for USB Type-C orientation switch
Xu Yang <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <ptjibaymaq2spiww7b35xv5cvvwu5wlwdo2jchvizzxt3w5wpn@dwzph5kz2f4a> |
On Wed, Aug 19, 2026 at 10:33:40AM -0500, Frank Li wrote: > On Wed, Aug 19, 2026 at 03:04:02PM +0000, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > > - [High] The GPIO hog for the CBTU02043 XSD pin incorrectly drives the physical pin HIGH instead of LOW, placing the switch in shutdown mode. > > - [High] The `pinctrl-names` and `pinctrl-0` properties inside the `gpio-hog` child node will be silently ignored by the `pinctrl` core. > > -- > > both look likes make sense. I just tested the patch on i.MX8MP EVK. Yes, CBTU02043 XSD pin is always high level and SuperSpeed USB device can only be detected as High-speed. Thanks, Xu Yang