Re: [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers
Wolfram Sang <[email protected]>
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-rtc |
|---|---|
| Message-ID | <aon271wPK9H8gAvR@ninjato> |
On Fri, Aug 21, 2026 at 09:26:11PM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: > > Pre-existing issues: > - [High] Data race and TOCTOU in IRQ handler leading to spurious interrupts and incomplete synchronization > - [High] Hardware state lockup on timeout in rzn1_rtc_set_time() > - [High] Alarm logic erroneously uses 1-second interrupt for past alarms with the same minute > - [Medium] Race window in rzn1_rtc_read_time() fallback logic can produce inconsistent timestamps All pre-existing issues, should be handled incrementally.
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmqJ9uwACgkQFA3kzBSg KbYhVw//XlKbkez+l3VpHjspOjHLYiThzVPLaQfz9QAfA9pELhV28RX4kX/HwXm7 3H66yxD9zqmkYlC56UMHLtIxQWIY1h3Fo0m+KOKawR60VbqJkoGtY28r4qvFUttm DOdIAHdaZWGNuMowccKItbz+9gepROsKqwl8mqAGk5Wt/g6sN0dLgJm/xQZgbHmP xNWdqBJ1nzC/Ax268hkPvjn00rwgX+KIPgc43mcbzlN78hAU5/t1IMQCWCh0V0mS OP5dGZg8cIsBTJbH1WKMr9cTRIpM2Ax1in/gT5FyFIxfNRMXOEBXm1RKs5v25MNj fooQE6bCfO+kanxgf7z3UWIRYdyLhOZIjl1WpRprRKFHHoSY+rfvix+SFmmFerLk U22qmxP+yYfVlhe3D7txrYUTzX1m3eS7nfKnIOtWPVjND/cvTo0W02sKvSOSXaGW 9WzdKr6NoQD2GKipB8uEm3scKkx/NOXbAbJ9GHdvdmHebgHXgVEoKtvAx0Hzovch hTdHCF5+MeczpChCB9B/Gnrca/xtwwe4rgJE2OuLQVMEh6ByW7OjI+ZxfjPVn1ML AGXb70dPPJNESURoYMGgxV5xdxmZDXVMbA0g++mg0PzcHHeOqWyHkn5x5FV+BRV1 U8h+PQMHrVVx1Lm1GD54ZvtqmQih4OQz+mpUdfNTYd5PKK1i5bk= =NvrB -----END PGP SIGNATURE-----