Re: Delivering reviews over email

On Wed, Apr 15, 2026 at 01:04:39AM +0000, Roman Gushchin <[email protected]> wrote:
> Sashiko is now able to send reviews over email.

Great job! E-mail interface is something I've been looking forward to.

> If you're interested in your subsystem to get email reviews,
> please, write into this mailing list or me directly or send a PR changing
> this file:
> https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml

Roman, IIUC, this considers maintainers as all non-ML addresses that are
CC'd in the original posting?

> Please, make sure all maintainers in the subsystem are onboard.

Tejun, Johannes, would you be OK with the change below?

(This would be a query based on MAINTAINERS entry, however, I'm afraid
the config change below may imply sending messages to all CC'd non-ML
addresses. So I may need to ask more people...)

> I also have a slight preference to not use reply_all and keep the cc
> list relatively short to not pollute all mailing lists.

My idea is only use this as notification to maintainers about existing
review findings whereas the content is always available publicly in the
web interface, i.e. do not send the review output to the cgroup ML (so
far?).

Thanks,
Michal


--- a/sashiko.dev/email_policy.toml
+++ b/sashiko.dev/email_policy.toml
@@ -47,3 +47,8 @@ cc = ["[email protected]"]
 [subsystems.net]
 lists = ["[email protected]"]
 embargo_hours = 24
+
+[subsystems.cgroups]
+lists = ["[email protected]"]
+reply_to_author = true
+cc_maintainers = true

-----BEGIN PGP SIGNATURE-----

iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaeZZmxsUgAAAAAAEAA5t
YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AhQwAEAr2dRJkIgmnEgmkoEyCg9
oNFeUJOovJ/tcGnjFuzai9YBAN0s6rJpVhvOtYmNjMWQFph70tTZ6Ds1SjI8BJzz
D7cB
=CX0I
-----END PGP SIGNATURE-----