Re: [PATCH v9 1/2] dt-bindings: embedded-controller: Add synology microp devices

Markus Probst <[email protected]> Fri, 24 Apr 2026 12:11:42 +0000

Newsgroups	dev.linux.lists.sashiko
Message-ID	<[email protected]>

On Thu, 2026-04-23 at 20:12 +0000, [email protected] wrote:
> Sashiko AI review found 1 potential issue(s):
> - [Low] Unused `#include <dt-bindings/leds/common.h>` in the device tree example snippet.
> --
> 
> commit 64a5fa0da12674dff6fa2aa515d134709ad0a024
> Author: Markus Probst <[email protected]>
> 
> dt-bindings: embedded-controller: Add synology microp devices
> 
> This commit adds the devicetree bindings for the Synology Microp
> microcontroller found on Synology NAS devices. The device is connected
> over a serial port and provides functionality for fans, LEDs, beepers,
> buttons, and system power management.
> 
> > diff --git a/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
> > new file mode 100644
> > index 0000000000000..b87034691885d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds918p-microp.yaml
> 
> [ ... ]
> 
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/leds/common.h>
> 
> This isn't a bug, but is this include needed here?
> 
> Neither the example nor the schema defines or uses any LED-related macros,
> properties, or child nodes. It appears the driver handles LED configurations
> internally based on the compatible string rather than parsing them from the
> device tree, which leaves this include unused.
Will be removed in next revision.

Thanks
- Markus Probst

> 
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    embedded-controller {
> > +      compatible = "synology,ds923p-microp", "synology,ds918p-microp";
> > +
> > +      fan-failure-gpios = <&gpio 68 GPIO_ACTIVE_HIGH>, <&gpio 69 GPIO_ACTIVE_HIGH>;
> > +    };

signature.asc (application/pgp-signature, 870 B)