Re: [PATCH v9 2/2] platform: Add initial synology microp driver

On April 26, 2026 2:49:56 PM GMT-03:00, Miguel Ojeda <[email protected]> wrote:
>On Sun, Apr 26, 2026 at 7:32 PM Arnaldo Melo <[email protected]> wrote:
>>
>> But if the AI is unconvinced that it is a false positive?
>>
>> Replying with a reason justifying why one thinks it's a false positive seems reasonable.
>>
>> I'm trying to avoid the, sometimes long, back and forth by using a local sashiko instance, using corporate keys (will try with local models soon) to reduce the traffic in the mailing list.
>>
>> Plainly stating that's a false positive seems to harsh and potentially harmful, no?
>
>Yeah, authors would ideally still mention in their reply near the
>"command tag" why they think it is a false positive. If they do so,
>and Sashiko considers it still to be a false positive, then Sashiko
>could still add it again in the new version.
>
>I was mainly trying to provide an "as-minimal-as-possible" option for authors.


Right, and I understand that we need to be careful now and tune responses.

My current pet peeve, that I'm trying to adjust to is sashiko pointing out unrelated pre-existing (potential) bugs.

I think it would be great to separate that from the per patch analysis and leave it to a suggestion for a follow-up series provided as a end of review email.

Otherwise it's too tempting to do just this extra fix and postpone finally sending a series for review, which ends up being sashiko again...

Some sort of help on making progress in actually merging fixes while helping suggest further following work seems advisable.

Best regards,

- Arnaldo