Re: [PATCH v1 1/2] thermal: hwmon: Register one hwmon device for each thermal zone

On Thu, Apr 23, 2026 at 12:07 AM <[email protected]> wrote:
>
> Sashiko AI review found 5 potential issue(s):
> - [Critical] UAPI Breakage by changing existing hwmon device names

This is done on purpose as explained in the changelog and if it really
breaks user space for somebody, the entire approach will need to be
changed (to something much less attractive).

> - [High] Buffer truncation during hwmon name construction defeats disambiguation

That problem is unlikely to happen, but formally it is a genuine one.
It will be addressed in the v2 of the patch.

> - [High] Kernel panic during thermal zone removal due to conditionally re-evaluating hardware-dependent state

That issue exists in the current code.  I'll add a patch to address it in v2.

> - [Medium] Subsystem Guideline Violation: Mixing goto and scoped_guard

Good point, will fix it up in v2.

> - [Low] Unused dead code (hwmon_node) left in struct thermal_hwmon_temp

This will also be addressed in v2.

Thanks!