AW: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity
| Newsgroups | dev.linux.lists.sashiko,org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <[email protected]> |
Hi bot, > Von: [email protected] <[email protected]> > Gesendet: Freitag, 1. Mai 2026 14:46 > An: Markus Stockhausen <[email protected]> > Cc: [email protected] > Betreff: Re: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity > > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > - [High] The active-high alert polarity configuration is completely ignored by the hardware because it is not added to the register update mask. > - [High] LM75_ALERT_POLARITY_HIGH_16_BIT targets the wrong byte of the configuration register. > - [High] Changing the AS6200 default from active-high to active-low breaks devicetree backward compatibility. unsure if answering to you helps both of us further. So my 2 cents only shortly: - Issue 1: Existing definitions for tmp1XX devices do not not obey "clr_mask is superset of set_mask". - Issue 2: AS6200 datasheet states BIT(10) is polarity. Thus .set_mask = 0x94C0 can only align one way. - Issue 3: Please advise. Best regards. Markus