AW: AW: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity
| Newsgroups | dev.linux.lists.sashiko,org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <[email protected]> |
> Von: Guenter Roeck <[email protected]> Im Auftrag von Guenter Roeck > Gesendet: Freitag, 1. Mai 2026 19:38 > Betreff: Re: AW: [PATCH 2/2] hwmon: (lm75) Support active-high alert polarity > ... >>> - [High] The active-high alert polarity configuration is completely ignored by the hardware because it is not added to the register update mask. >>> - [High] LM75_ALERT_POLARITY_HIGH_16_BIT targets the wrong byte of the configuration register. >>> - [High] Changing the AS6200 default from active-high to active-low breaks devicetree backward compatibility. >> >> unsure if answering to you helps both of us further. So my 2 cents only shortly: >> >> - Issue 1: Existing definitions for tmp1XX devices do not not obey "clr_mask is superset of set_mask". > > I think you are saying that this is a pre-existing bug and that set_mask is effectively > ignored. Is that a reason not to fix the problem ? > ... > 2) Fix lm75_write_config() to add set_mask to clr_mask to ensure > that the bits which are supposed to be set are actually set. I did not expect a bug in the current driver and was baffled by the bots response. From your feedback that qualifies a "Fixes" tag. Am I right to assume that 6da24a2 ("hwmon: (lm75) Hide register size differences in regmap access functions") is the commit to blame? Markus