Re: [PATCH 1/6] watchdog: Fix wrong SPDX license identifier

On 5/4/26 04:17, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The commit claims to fix a checkpatch warning by replacing `GPL-2.0` with `GPL-2.0-only`, but the kernel's checkpatch does not warn about `GPL-2.0` in this context, making the change unnecessary churn based on a false premise.
> --
> 
> commit b8d17764218e572db22388434473471ed009998c
> Author: Philipp Hahn <[email protected]>
> 
> watchdog: Fix wrong SPDX license identifier
> 
> This commit updates the SPDX license identifier in the watchdog
> documentation from GPL-2.0 to GPL-2.0-only.
> 
>> The identifier GPL-2.0 has been deprecated in favor of GPL-2.0-only.
>> Change it to silence checkpatch.
> 
> Is this description accurate regarding checkpatch?
> 
> Looking at scripts/checkpatch.pl, it only enforces GPL-2.0-only for files
> under Documentation/devicetree/bindings/ and include/dt-bindings/.
> 
> Additionally, LICENSES/preferred/GPL-2.0 explicitly defines GPL-2.0 as a
> valid identifier in the Linux kernel.
> 
> Since checkpatch does not emit warnings for GPL-2.0 in generic subsystem
> documentation like Documentation/watchdog/index.rst, does this change
> introduce unnecessary churn?
> 
linux-next$ scripts/checkpatch.pl --strict -f Documentation/watchdog/index.rst
total: 0 errors, 0 warnings, 0 checks, 18 lines checked

Documentation/watchdog/index.rst has no obvious style problems and is ready for submission.

Please refrain from unnecessary churn, and from making false statements
("to silence checkpatch").

Guenter