Re: [PATCH v2 3/3] perf build: Remove NO_GTK2 build test

On Mon, May 04, 2026 at 06:47:59AM +0000, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The commit removes the `NO_GTK2` test cases but fails to add `make_with_gtk2` to the `run` list, leaving the opt-in GTK2 build entirely untested.
> --
> 
> commit a080179ce5f6a893edba859d130afb3b6367e133
> Author: Namhyung Kim <[email protected]>
> 
> perf build: Remove NO_GTK2 build test
> 
> This commit removes the obsolete NO_GTK2 build targets since GTK2 support
> was previously made opt-in. It updates the build-test configuration by
> removing make_no_gtk2, make_no_ui, and updating make_minimal.
> 
> > diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> > index 6587dc326d1b..dbd7c86a2dcc 100644
> > --- a/tools/perf/tests/make
> > +++ b/tools/perf/tests/make
> [ ... ]
> > @@ -153,8 +151,6 @@ run += make_libperl
> >  run += make_no_libpython
> >  run += make_no_scripts
> >  run += make_no_slang
> > -run += make_no_gtk2
> > -run += make_no_ui
> >  run += make_no_demangle
> >  run += make_no_libelf
> >  run += make_no_libdw
> 
> Does this leave the GTK2 build entirely untested?
> 
> The commit message states "we need to pass GTK2=1 to enable it. Let's
> update the build-test configuration for that."
> 
> However, after removing these targets, there doesn't appear to be a
> corresponding addition to the run list (such as run += make_with_gtk2)
> to actually test the opt-in GTK2 build path.

This is handled separately in tools/perf/Makefile.

Thanks,
Namhyung