Re: [feature suggestion] fixup patch review

SeongJae Park <[email protected]>
Newsgroups dev.linux.lists.sashiko
Message-ID <[email protected]>
On Wed, 15 Apr 2026 01:11:11 +0000 Roman Gushchin <[email protected]> wrote:

> SeongJae Park <[email protected]> writes:
> 
> > Hello,
> >
> >
> > When a large patch series is posted and an issue on a single patch is found, it
> > is useful to post a fixup patch as a reply to the review, instead of posting
> > the entire new version of the series.  It is useful for doing quick reviews
> > without polluting mailing list and reviewer's inbox.  But it seems sashiko is
> > not reviewing such fixup.  Would it be possible to make sashiko understand and
> > review such fixup patches?
> 
> Hi SJ,
> 
> sorry for the late reply!

No worries, it is never urgent!

> 
> I like the idea but realistically I'm not sure I'll have time to work on
> it short-term. These follow-up fixes are often too context-heavy, e.g.
> are raw untested ideas or are drop-in replacements for some patch in the
> series, so accurately handling all edge-cases might be not exactly trivial.

Thank you for kindly explaining the challenges, I totally agree that.  Having a
sort of command-like reply rule for giving the context in easier and explicit
way, like syzkaller [1], might make it easier, though?

Nevertheless, this is never a urgent feature request but just an attempt to do
FWIW brainstorm discussion.  So no push, no rush!

[1] https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches


Thanks,
SJ
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.