Re: [PATCH v6 1/2] dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge

在 2026/5/9 4:50, [email protected] 写道:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] The binding lacks support for the dual-port MIPI DSI output claimed in the commit message.

1. When using single-port mode:
   (a). Only either Port A or Port B can be output at a time.
   (b). Port A and Port B are combined into a single port to output 
8-lane DSI.

2. When using dual-port mode:
Port A outputs the signal, and Port B copy the same signal from Port 
A.Both ports output the same image, and configuration for Port A alone 
is sufficient.

I need to look into how to modify it.

> - [Low] Typographical errors in the commit message alter the meaning and reduce clarity.
      it will be fixed.> --
> 
> commit d7e3500f4741bb0ae26a44a80c52b86455bf1c05
> Author: Sunyun Yang <[email protected]>
> 
> dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge
> 
> This commit adds the device tree binding schema for the Lontium LT7911EXC.
> This device is an I2C-controlled bridge that converts eDP 1.4 input to MIPI
> DSI output.
> 
>> The LT7911EXC is an I2C-controlled bridge that Receiver eDP1.4
>> and output signal/dual port mipi dsi.
> 
> This isn't a bug, but there appear to be a few typos in the commit message
> description. The word Receiver reads like it should be receives, and the
> word signal looks like a typo for single.
> 
it will be fixed in next version.

>> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
>> new file mode 100644
>> index 0000000000000..3290b10ce8835
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> 
> [ ... ]
> 
>>    ports:
>>      $ref: /schemas/graph.yaml#/properties/ports
>>
>>      properties:
>>        port@0:
>>          $ref: /schemas/graph.yaml#/properties/port
>>          description: Video port for eDP input.
>>
>>        port@1:
>>          $ref: /schemas/graph.yaml#/properties/port
>>          description: Video port for MIPI DSI output.
> 
> Since the commit message indicates the hardware supports dual port MIPI DSI
> output, should the schema define a secondary DSI interface here?
> 
> Without a second endpoint or an additional port defined, it seems device
> tree authors would be unable to properly model a dual-port display panel
> connection.
>