RE: [PATCH 2/2] hwmon: (pmbus/max20830) add driver for max20830
"Torreno, Alexis Czezar" <[email protected]>
| Newsgroups | dev.linux.lists.sashiko,org.kernel.vger.linux-hwmon |
|---|---|
| Message-ID | <PH0PR03MB635179B8E59E60DB994415A7F1222@PH0PR03MB6351.namprd03.prod.outlook.com> |
> On 4/13/26 21:56, [email protected] wrote: > > Sashiko AI review found 3 potential issue(s): > > - [Medium] The driver incorrectly uses `i2c_smbus_read_i2c_block_data` > instead of `i2c_smbus_read_block_data`, violating the protocol and logging an > untrusted binary buffer. > > - [Low] The MODULE_IMPORT_NS macro uses an unquoted identifier, > resulting in a build failure. > > - [Low] The sysfs attribute `in2_alarm` is created but not documented. > > -- > > > > The reported issues seem real. Please address. > Will fix the missing in2_alarm and lacking quotes in MODULE_IMPORT_NS macro I may need to keep i2c_smbus_read_i2c_block_data. I'm testing this on an rpi4 and it seems i2c_smbus_read_block_data isn't supported by the adapter. Regards, Alexis