RE: [PATCH v6 net-next 05/15] net: enetc: add support for the "Add" operation to VLAN filter table

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to
> consider:
> - [Low] Missing dummy implementation for `ntmp_vft_add_entry` when
> `CONFIG_NXP_NETC_LIB` is disabled.
> --
> 
> commit 5e0769b9fed651ba9fec062f5b68e9fec7739814
> Author: Wei Fang <[email protected]>
> 
> net: enetc: add support for the "Add" operation to VLAN filter table
> 
> This commit adds support for the Add operation to the VLAN filter table
> for the enetc switch driver. It introduces the ntmp_vft_add_entry helper
> function to facilitate adding entries using the table management protocol.
> 
> > diff --git a/include/linux/fsl/ntmp.h b/include/linux/fsl/ntmp.h
> > index 4cfff835954e5..3672e0dc7726b 100644
> > --- a/include/linux/fsl/ntmp.h
> > +++ b/include/linux/fsl/ntmp.h
> 
> [ ... ]
> 
> > @@ -125,6 +147,8 @@ int ntmp_fdbt_delete_entry(struct ntmp_user *user,
> u32 entry_id);
> >  int ntmp_fdbt_search_port_entry(struct ntmp_user *user, int port,
> >  				u32 *resume_entry_id,
> >  				struct fdbt_entry_data *entry);
> > +int ntmp_vft_add_entry(struct ntmp_user *user, u16 vid,
> > +		       const struct vft_cfge_data *cfge);
> >  #else
> >  static inline int ntmp_init_cbdr(struct netc_cbdr *cbdr, struct device *dev,
> >  				 const struct netc_cbdr_regs *regs)
> 
> Does this need a dummy implementation for ntmp_vft_add_entry() in the #else
> block?
> 
> Other functions in this file have a static inline stub when
> CONFIG_NXP_NETC_LIB is disabled. Without a stub here, configurations where
> the caller is built but the library is not might encounter build failures
> due to an undefined reference or implicit declaration.
> 

No need to add a dummy implementation for ntmp_vft_add_entry(), this function
is only called by NETC switch driver, and the driver will select NXP_NETC_LIB. So
ntmp_vft_add_entry() is always defined if NETC switch driver is built.

This is a false positive, please ignore it.