Re: [PATCH v7 15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() and __legacy_mmap_fits()

Krzysztof WilczyƄski <[email protected]> Mon, 11 May 2026 16:14:20 +0900
Newsgroups dev.linux.lists.sashiko,org.kernel.vger.linux-pci
Message-ID <20260511071346.GC1096586@rocinante>
Hello,

> > > >  static int __legacy_mmap_fits(struct pci_controller *hose,
> > > >  			      struct vm_area_struct *vma,
> > > > -			      unsigned long res_size, int sparse)
> > > > +			      unsigned long res_size)
> > > 
> > > This isn't a bug, but since the WARN() statement that used hose->index was
> > > removed below, is the hose parameter still needed? It appears to be completely
> > > unused in the function body now.
> > 
> > Ah, yes, darn.  Forgot to remove this one, too.  A quick fix:
> 
> I squashed this in, but you should double-check it because it didn't
> apply cleanly.

Looks good!  Thank you!

	Krzysztof