Re: [PATCH v2 3/4] arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb

Am 12.05.26 um 04:43 schrieb [email protected]:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [Medium] The composite DTB targets for the RZ/V2L board are missing the '-iiot' identifier, leading to inconsistent naming.
> - [Medium] The shared device tree overlays are not added to the install targets for the R9A07G054 architecture.
> - [Low] The `-dtbs` composite variables are populated using `+=` instead of `:=`.
> --
>
> commit 1346fdf98939d24bedd9085cb7ddffee29247fcf
> Author: Josua Mayer <[email protected]>
>
> arm64: dts: renesas: add support for solidrun rzv2l som and hb-iiot evb
>
> This commit adds device tree support for the SolidRun RZ/V2L SoM on the
> HummingBoard IIoT platform. It utilizes shared code and device tree overlays
> from the existing RZ/G2L series.
>
>> diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
>> index 37cfefe66a308..cdf59f3240e27 100644
>> --- a/arch/arm64/boot/dts/renesas/Makefile
>> +++ b/arch/arm64/boot/dts/renesas/Makefile
>> @@ -188,6 +188,15 @@ dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtbo
>>  r9a07g044l2-smarc-cru-csi-ov5645-dtbs := r9a07g044l2-smarc.dtb r9a07g044l2-smarc-cru-csi-ov5645.dtbo
>>  dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtb
>>  
>> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-iiot.dtb
> Should the shared device tree overlays be explicitly added to the install
> targets for CONFIG_ARCH_R9A07G054?
They should, though building for one platform without the other is unlikely.

Queued for v3.

>
> Currently, overlays like rzg2l-sr-som-emmc.dtbo and
> rzg2l-hummingboard-iiot-microsd.dtbo are built as intermediate dependencies,
> but Kbuild's make dtbs_install only installs artifacts present in dtb-y.
> Without being added to dtb-$(CONFIG_ARCH_R9A07G054), will these standalone
> .dtbo files be missing from the installation directory?
>
>> +r9a07g054l2-hummingboard-emmc-dtbs += r9a07g054l2-hummingboard-iiot.dtb rzg2l-sr-som-emmc.dtbo
>> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-emmc.dtb
> Are these composite DTB targets missing the -iiot identifier?

Correct.

Queued for v3

>
> The base board is named r9a07g054l2-hummingboard-iiot.dts, but the targets
> omit -iiot (for example, r9a07g054l2-hummingboard-emmc.dtb). The equivalent
> RZ/G2L targets correctly include it, such as
> r9a07g044l2-hummingboard-iiot-emmc.dtb.
>
> Could this naming discrepancy cause issues for deployment scripts
> expecting the -iiot substring to locate the RZ/V2L DTBs?
>
> Also, this isn't a bug, but is it intentional to use += instead of := for
> these composite variables?
Unintentional copy from other examples.
>
> In Kbuild, := is generally the standard convention for defining multi-DTB
> targets, as seen in the surrounding Makefile entries.
Queued for v3.
>
>> +r9a07g054l2-hummingboard-microsd-dtbs += r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-microsd.dtbo
>> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-microsd.dtb
>> +r9a07g054l2-hummingboard-rs485-a-dtbs += r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-rs485-a.dtbo
>> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-rs485-a.dtb
>> +r9a07g054l2-hummingboard-rs485-b-dtbs += r9a07g054l2-hummingboard-iiot.dtb rzg2l-hummingboard-iiot-rs485-b.dtbo
>> +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-hummingboard-rs485-b.dtb
> [ ... ]
>