Re: [PATCH v3 01/10] ASoC: dt-bindings: renesas,fsi: add support multiple clocks

On Tue, May 12, 2026 at 01:42:06PM +0700, Bui Duc Phuc wrote:
> Hi all,
> 
> Based on the Sashiko AI review, I am thinking of adding the following
> constraints specifically for renesas,fsi2-r8a7740 to address the
> reported issues.
> 
> I think this may also help balance both Geert's and Krzysztof's
> comments from the previous v2 review.
> 
> Does this approach look reasonable to you?
> 
> ---------------------------------------------
> 
> -allOf:
> -  - $ref: dai-common.yaml#
> -
>  properties:
>    $nodename:
>      pattern: "^sound@.*"
> @@ -94,6 +91,78 @@ required:
> 
>  unevaluatedProperties: false
> 
> +allOf:
> +  - $ref: dai-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,fsi2-r8a7740
> +    then:
> +      properties:
> +        clock-names:
> +          oneOf:
> +            - items: # FSIA & FSIB is slave
> +                - const: fck
> +                - const: spu
> +            - items: # FSIA slave & FSIB master use internal clock
> +                - const: fck
> +                - const: spu
> +                - const: ickb
> +                - const: divb
> +            - items: # FSIA slave & FSIB master use external clock
> +                - const: fck
> +                - const: spu
> +                - const: ickb
> +                - const: xckb
> +            - items: # FSIB slave & FSIA master use internal clock
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: diva
> +            - items: # FSIB slave & FSIA master use external clock
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: xcka
> +            - items: # FSIA master ex-clk  & FSIB master ex-clk
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: xcka
> +                - const: ickb
> +                - const: xckb
> +            - items: # FSIA master in-xlk  & FSIB master in-clk
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: diva
> +                - const: ickb
> +                - const: divb
> +            - items: # FSIA master in-clk  & FSIB master ex-clk
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: diva
> +                - const: ickb
> +                - const: xckb
> +            - items: # FSIA master ex-clk  & FSIB master in-clk
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: xcka
> +                - const: ickb
> +                - const: divb
> +            - items: # FSIA & FSIB  full clock support
> +                - const: fck
> +                - const: spu
> +                - const: icka
> +                - const: xcka
> +                - const: diva
> +                - const: ickb
> +                - const: xckb
> +                - const: divb

Between this and just giving up on enforcing an order, I pick the 
latter.

Rob