Re: [PATCH v13 4/5] media: qcom: camss: csid: Add support for CSID gen4

On 5/31/2026 8:38 AM, [email protected] wrote:
>>
>> [ ... ]
>>
>>> +static void __csid_configure_rdi_stream(struct csid_device *csid, u8 enable, u8 port, u8 vc)
>>> +{
>>> +	u32 val;
>>> +	u8 lane_cnt = csid->phy.lane_cnt;
>>> +
>>> +	/* Source pads matching RDI channels on hardware.
>>> +	 * E.g. Pad 1 -> RDI0, Pad 2 -> RDI1, etc.
>>> +	 */
>>> +	struct v4l2_mbus_framefmt *input_format = &csid->fmt[MSM_CSID_PAD_FIRST_SRC + port];
>>
>> The macro MSM_CSID_MAX_SRC_STREAMS_GEN4 evaluates to 5 for non-lite CSID
>> hardware, meaning the loop index port can reach 4.
>>
>> Since MSM_CSID_PAD_FIRST_SRC is 1, MSM_CSID_PAD_FIRST_SRC + port evaluates
>> to 5.
> 
> That's worrying.
> 
> Would appreciate some follow-up from patch authors on this one "yes we
> looked no that can't happen" "yes we looked no it can't happen"
> 
> Either is acceptable.
It cannot happens as we have limited the vfe_line number to 3 due to 
camss framework limitation.

Best regards,
Hangxiang