Re: Sashiko reviews for the LSM mailing list
Paul Moore <[email protected]> Mon, 15 Jun 2026 16:13:59 -0400
| Newsgroups | dev.linux.lists.sashiko,org.kernel.vger.linux-security-module |
|---|---|
| Message-ID | <CAHC9VhQxHEuznN-xiMJ-LCsz2z-UB0ri6MeMn+Ajyn1WUTDNDw@mail.gmail.com> |
On Mon, Jun 15, 2026 at 11:41=E2=80=AFAM Micka=C3=ABl Sala=C3=BCn <mic@digi= kod.net> wrote: > > Hi, > > I've been reading Sashiko's (AI bot) reviews wrt Landlock patches, and > most of them were valuable. It found issues (security or not), but it > requires to go to https://sashiko.dev to find them, which is too easy to > forget, and requires additional work from maintainers to copy or point > to these reviews. I sent a PR (currently in draft) to enable email > replies from Sashiko to the Linux Security Module mailing list (most > patches are already reviewed anyway): > https://github.com/sashiko-dev/sashiko/pull/278 > > Making such reviews broadly available can improve the quality of patches > we receive without much noise, helping for all LSM-related code. We can > fine tune some email-related settings if needed. > > If there are any concern or question, this is the right time to start a > discussion. I recently enabled Sashiko for the SELinux list to trial it there first, with the goal of eventually bringing this topic up for the rest of the LSM folks on the LSM list. While I think Sashiko's review comments are generally okay, you should have contacted the LSM mailing list folks *before* submitting a PR that would cause an automated bot to send email to the LSM list (this applies to all automated emails, not just LLM reviews). Please hold the PR until you have given people a chance to comment on the issue. Personally, I'm okay with it. -- paul-moore.com