Re: [PATCH v2] Squashfs: check block offset is not negative

On 06/08/2026 19:09, Phillip Lougher wrote:
> 
> 
> On 06/08/2026 18:44, Derek Barbosa wrote:
> 
>> Yes. It seems like Sashiko is selecting the incorrect baseline here. However,
>> from what I can see in baseline.rs, Sashiko pulls the mainline MAINTAINERS entry
>> and parses it to find whatever "matched" subsystem it could detect from the
>> patches.
>>
>>  From Torvald's tree (remote:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git) with HEAD at
>> fcaeecb8b0cd44f77d03b28de0671258d4db18f8
>>
>> SQUASHFS FILE SYSTEM
>> M:    Phillip Lougher <[email protected]>
>> L:    [email protected] (subscribers-only)
>> S:    Maintained
>> W:    http://squashfs.org.uk
>> T:    git git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-next.git
>> F:    Documentation/filesystems/squashfs.rst
>> F:    fs/squashfs/
>>
>> I may be mistaken, but maybe updating the "T:" entry would resolve the issues
>> you are seeing? Is this the same tree that you described as "purged"/unused?
>>
> 
> Yes, the git URL (the T: entry) is out of date.
> 
> But, until you mentioned it now, I didn't know it existed,
> because I never added it.
> 
> It was added in commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f273c24ec5f4
> 
> author    Fengguang Wu <[email protected]>    2016-01-20 15:03:25 -0800
> committer    Linus Torvalds <[email protected]>    2016-01-20 17:09:18 -0800
> commit    9f273c24ec5f4a6f785bb83e931b3808a07b459e (patch)
> tree    7bc0126edb6ded71bec82e4c057768d76928b2f5
> parent    b2807f07f4f87362925b8a5b8cbb7b624da10f03 (diff)
> download    linux-9f273c24ec5f4.tar.gz
> MAINTAINERS: add/fix git URLs for various subsystems
> 
> @@ -10217,6 +10242,7 @@ SQUASHFS FILE SYSTEM
>   M:    Phillip Lougher <[email protected]>
>   L:    [email protected] (subscribers-only)
>   W:    http://squashfs.org.uk
> +T:    git git://git.kernel.org/pub/scm/linux/kernel/git/pkl/squashfs-next.git
>   S:    Maintained
>   F:    Documentation/filesystems/squashfs.txt
>   F:    fs/squashfs/
> 
> I will send a patch to remove it.
> 
> Thanks
> 
> 

I have sent a patch to remove that dead URL from the MAINTAINERS file.

But, the point is, is that enough to make Sashiko default to using Linus
Torvald's upstream development kernel for Squashfs patches?

As I said previously I lost access to git.kernel.org in 2015 (if you ask
why I will tell you privately).  So I can't put a kernel tree on there,
but I could on Github (the kernel is already on Github and so it will be a
simple fork).  But it seems a PITA to do that just for Sashiko.

Phillip
   >>
>> Thanks,
>>
> 
s