Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: add max20830

Krzysztof Kozlowski <[email protected]> writes:

> On Tue, Apr 14, 2026 at 04:38:40AM +0000, [email protected] wrote:
>> Sashiko AI review found 3 potential issue(s):
>> - [Medium] Incomplete Regulator Schema
>> - [Medium] Missing Hardware Capability (Interrupts)
>> - [Low] Devicetree Best Practices Violation (Node Name)
>> --
>> 
>> commit 20a4d8dcd2f3344ac22d7d2e974bae1ef57874ed
>> Author: Alexis Czezar Torreno <[email protected]>
>> 
>> dt-bindings: hwmon: pmbus: add max20830
>> 
>> This commit adds device tree documentation for the MAX20830 step-down DC-DC
>> switching regulator with PMBus interface. It allows monitoring of voltage,
>> current, and temperature.
>
> Sashiko devs,
> Can we drop such comments? They are useless - we know what the commit is
> doing, no point for reviewing tool to say it again.

It's the format which originated from initial Chris Mason's prompts
and as *I understand* it's purpose was to make sure the llm is reviewing
the right patch and more or less understands it. Idk if we still need
this, but at least some find it useful: e.g.
https://github.com/sashiko-dev/sashiko/issues/90 .

I'm planning to do it configurable in UI, but for emails I can
only make it configurable on per-subsystem basis.
If there is a consensus amongst hwmon maintainers, I'm happy to remove
it for hwmon (in several days).

>
> Please send only useful feedback to mailing list, otherwise this will be
> just noise and going to be ignored.

Agree, but there are many sometimes conflicting opinions on what's
useful and what's not. So I'm trying to make it as flexible and
configurable as possible.

Thanks