Re: [PATCH sched_ext/for-7.3] tools/sched_ext/include: Regenerate enum_defs.autogen.h
[email protected] Sun, 26 Jul 2026 22:00:16 +0000
| Newsgroups | dev.linux.lists.sched-ext |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The patch updates `enum_defs.autogen.h` to replace `HAVE_SCX_REE= NQ_LOCAL_MAX_REPEAT` with `HAVE_SCX_REENQ_MAX_REPEAT`, but the correspondin= g enum rename is missing from the kernel C source code (`kernel/sched/ext/t= ypes.h`). -- --- Patch [1]: [PATCH sched_ext/for-7.3] tools/sched_ext/include: Regenerat= e enum_defs.autogen.h --- commit 87802be8777491b94ab77d3e645df530fc777b45 Author: Tejun Heo <[email protected]> tools/sched_ext/include: Regenerate enum_defs.autogen.h =20 Regenerate enum_defs.autogen.h from the current vmlinux.h to pick up the SCX enum changes accumulated since the last regeneration. Link: https://lore.kernel.org/all/amZsEbZJdDgjstPF@gpd4/ > Regenerate enum_defs.autogen.h from the current vmlinux.h to pick up the = SCX > enum changes accumulated since the last regeneration, including the > SCX_REENQ_LOCAL_MAX_REPEAT to SCX_REENQ_MAX_REPEAT rename. [Severity: Medium] Is the SCX_REENQ_LOCAL_MAX_REPEAT to SCX_REENQ_MAX_REPEAT rename actually present in this tree? Looking at kernel/sched/ext/types.h, the old enum name is still present: kernel/sched/ext/types.h: SCX_BYPASS_LB_BATCH =3D 256, =09 SCX_REENQ_LOCAL_MAX_REPEAT =3D 256, =09 SCX_SUB_MAX_DEPTH =3D 4, > diff --git a/tools/sched_ext/include/scx/enum_defs.autogen.h b/tools/sche= d_ext/include/scx/enum_defs.autogen.h > index da4b459820fdd..0379eff117c9e 100644 > --- a/tools/sched_ext/include/scx/enum_defs.autogen.h > +++ b/tools/sched_ext/include/scx/enum_defs.autogen.h [ ... ] > @@ -20,7 +37,7 @@ > #define HAVE_SCX_BYPASS_LB_DONOR_PCT > #define HAVE_SCX_BYPASS_LB_MIN_DELTA_DIV > #define HAVE_SCX_BYPASS_LB_BATCH > -#define HAVE_SCX_REENQ_LOCAL_MAX_REPEAT > +#define HAVE_SCX_REENQ_MAX_REPEAT [Severity: Medium] Will this cause build failures for BPF schedulers that check for HAVE_SCX_REENQ_MAX_REPEAT? They might get an undeclared identifier if the actual kernel source still exports SCX_REENQ_LOCAL_MAX_REPEAT in vmlinux.h instead of the new name. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/048d8cc6b8e9be48ec0= [email protected]?part=3D1