Re: [PATCH 02/17] sched/core: Dequeue waking proxy donors before reset

On Sun, Aug 16, 2026 at 07:35:00PM +0200, Andrea Righi wrote:
> +	if (reset_donor) {
> +		bool dequeued = dequeue_block_task(rq, p, TASK_WAKING);
> +
> +		/* Keep on_rq set until all donor references have been replaced. */
> +		proxy_reset_donor(rq);
> +		if (dequeued)
> +			__block_task(rq, p);
> +	} else {
> +		block_task(rq, p, TASK_WAKING);

nitpick, would the following be easier to follow?

        bool dequeued = dequeue_block_task(rq, p, TASK_WAKING);

	/* Keep on_rq set until all donor references have been replaced. */
	if (reset_donor)
        	proxy_reset_donor(rq);

        if (dequeued)
                __block_task(rq, p);


Thanks.

-- 
tejun