Re: [PATCH 2/2] compat.bpf.h: add scx_bpf_reenqueue_local_from_anywhere() compat helper

Tejun Heo <[email protected]>
Newsgroups dev.linux.lists.sched-ext,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hello, Changwoo.

On Mon, Aug 17, 2026 at 11:31:26PM +0900, Changwoo Min wrote:
> +	if (__COMPAT_scx_bpf_reenqueue_local_from_anywhere()) {
> +		scx_bpf_reenqueue_local___v2___compat();
> +		return 0;
> +	}
> +	return -ENOTSUP;

ENOTSUP is glibc-only. The BPF side picks up errno constants through
asm-generic/errno.h (see common.bpf.h), which only defines EOPNOTSUPP,
and as static inline bodies are checked in every TU whether called or
not, this breaks the BPF build for every scheduler. Use -EOPNOTSUPP like
__COMPAT_bpf_cpumask_populate() in the same file and update the
description accordingly. The pending scx-side PR needs the same fix.

The rest of the patch looks good to me.

Thanks.

--
tejun
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.