Re: [PATCH v2 05/19] ARM: turn CONFIG_ATAGS off by default

Hi, Arnd,

Looks good to me, though I noticed a few small issues.

On Wed, Jul 1, 2026 at 2:24 PM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> Only a very small number of machines remain that rely on
> traditional board files with the ATAGS boot data instead
> of devicetree, and we have not accepted new ones for
> a decade.
>
> Most of the remaining ones are on their way out of the
> kernel, but the Kconfig option that controls ATAGS
> is still enabled by default.
>
> To reflect the actual status of ATAGS support and alert
> the remaining users of upstream and out-of-tree platforms
> with this, chanyge it to being default-disabled and
nit: change*

> add a dependency on CONFIG_EXPERT.
>
> The board specific defconfig files that rely on ATAGS
> are changed to turn on both EXPERT and ATAGS if they
> were not doing thath already, and the ones that explicitly
nit: that*

> turned it off before no longer need to.

> --- a/arch/arm/configs/stm32_defconfig
> +++ b/arch/arm/configs/stm32_defconfig
> @@ -20,7 +20,8 @@ CONFIG_ARCH_STM32=y
>  CONFIG_CPU_V7M_NUM_IRQ=240
>  CONFIG_SET_MEM_PARAM=y
>  CONFIG_DRAM_BASE=0x90000000
> -# CONFIG_ATAGS is not set
> +CONFIG_FLASH_MEM_BASE=0x08000000
> +CONFIG_FLASH_SIZE=0x00200000

^ These shouldn't be here - they depend on CPU_ARM740T || CPU_ARM946E
|| CPU_ARM940T, and they were manually removed previously. If they got
added when you did make savedefconfig, I'm not sure why, given that
dependency.

Reviewed-by: Ethan Nelson-Moore <[email protected]> (assuming
these issues are fixed)

Ethan