Re: Re: [PATCH v2 07/10] pinctrl: ambarella: add Ambarella pin controller
Rob Herring <[email protected]>
| Newsgroups | dev.linux.lists.soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial |
|---|---|
| Message-ID | <CAL_JsqJprX0oC3Gdj=RNNYtPiQ-0NkEPvn-MyQ9ZtFakKcj1ew@mail.gmail.com> |
On Mon, Aug 10, 2026 at 2:42 PM Linus Walleij <[email protected]> wrote: > > On Mon, Aug 10, 2026 at 6:02 AM Long Zhao <[email protected]> wrote: > > > Thanks for the review. I will rework this to reuse the PL061 driver with > > per-variant register offsets, and evaluate modeling each GPIO bank as a > > separate DT entity. The duplicated GPIO implementation will be removed. > > Thanks Long, I think it will be easier if you break out the pin control > bindings and driver from the patch series and work on it separately, > the same with the serial driver at least. > > I understand this can be hard to test on the hardware, I usually > put a few patches "underneath" the b4 cover letter, and then the > b4 send-email will only send the cover letter and the patches > on top. The problem with that advice is then 'base-commit' is useless. Maybe b4 could learn an 'ignore the top N commits" or "only track the first N commits". Rob