Re: [PATCH v2 1/3] irqchip/sg2042-msi: Set irq type according to DT configuration

Thomas Gleixner <[email protected]>
Newsgroups dev.linux.lists.sophgo,org.infradead.lists.linux-riscv,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <87v7m10zk0.ffs@tglx>
On Tue, Aug 26 2025 at 09:09, Chen Wang wrote:
> From: Chen Wang <[email protected]>
>
> The original MSI interrupt type was hard-coded, which was not a good idea.

That's not really helpful, unless you explain WHY it's not a good
idea...

Also for correctness sake, you want to change the DTs first and not
after you changed the driver to read it from the stale device tree with
the wrong type.

Thanks,

        tglx
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.