Re: [PATCH v2 3/7] PCI: sg2042: Add Sophgo SG2042 PCIe driver

On 9/10/2025 10:56 AM, Inochi Amaoto wrote:
> On Wed, Sep 10, 2025 at 10:08:39AM +0800, Chen Wang wrote:

[......]

>> +static void sg2042_pcie_remove(struct platform_device *pdev)
>> +{
>> +	struct cdns_pcie *pcie = platform_get_drvdata(pdev);
>> +
>> +	cdns_pcie_disable_phy(pcie);
>> +}
>> +
> I think this remove is useless, as it is almost impossible to
> remove a pcie at runtime.

I think since we implemented the driver as a module, supporting remove 
is also a requirement for completeness. So I add this as per request 
from Manivannan in the last review.

Thanks，

Chen

> Regards,
> Inochi