Re: [PATCH] net: stmmac: dwmac-sophgo: Add phy interface filter
Andrew Lunn <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
> "rgmii-id" doesn't mean "there is a delay _somewhere_ in the system". > It's supposed to mean that the PHY should add delays on both tx and > rx paths. When passed to the PHY it means that. However, DT describes the hardware, the PCB. "rgmii-id" means the PCB does not provide the delays. So the MAC/PHY combination needs to add the delays. We normally have the PHY provide the delays, so the phy-mode is normally passed straight to the PHY. However, if the MAC is adding a delay, which it is in this case, in one direction and cannot be turned off, the value passed to the PHY needs to reflect this, to avoid double delays. And because the MAC delay cannot be turned off, it means there are PCB designs which don't work, double delays. So it would be nice not to list them in the binding. Andrew