Re: [PATCH v5 3/8] net: stmmac: qcom-ethqos: improve typing in devres callback
Konrad Dybcio <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-riscv,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <[email protected]> > > It's bad practice to just directly pass void pointers to functions which > expect concrete types. Make it more clear what type ethqos_clks_config() > expects. > > Signed-off-by: Bartosz Golaszewski <[email protected]> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 8578a2df8cf0d1d8808bcf7e7b57c93eb14c87db..8493131ca32f5c6ca7e1654da0bbf4ffa1eefa4e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -726,7 +726,9 @@ static int ethqos_clks_config(void *priv, bool enabled) > > static void ethqos_clks_disable(void *data) > { > - ethqos_clks_config(data, false); > + struct qcom_ethqos *ethqos = data; > + > + ethqos_clks_config(ethqos, false); ethqos_clks_config() takes a voidptr too Konrad