Re: [PATCH v5 2/8] net: stmmac: qcom-ethqos: use generic device properties
Konrad Dybcio <[email protected]>
| Newsgroups | dev.linux.lists.sophgo,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-riscv,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 11/13/25 2:18 PM, Bartosz Golaszewski wrote: > On Fri, Nov 7, 2025 at 11:49 AM Konrad Dybcio > <[email protected]> wrote: >> >> On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <[email protected]> >>> >>> In order to drop the dependency on CONFIG_OF, convert all device property >>> getters from OF-specific to generic device properties and stop pulling >>> in any linux/of.h symbols. >>> >>> Signed-off-by: Bartosz Golaszewski <[email protected]> >>> --- >> >> [...] >> >>> - if (of_property_read_bool(np, "snps,tso")) >>> + if (device_property_present(dev, "snps,tso")) >> >> This is a change in behavior - "snps,tso = <0>" would have previously >> returned false, it now returns true >> > > This property is a boolean flag, it cannot have a value. Every DT property may have a value, so this is not as obvious as we'd like it to be (IIUC - unless that changed recently) Konrad